Skip to content
This repository has been archived by the owner on Aug 21, 2018. It is now read-only.

Needs Spark rename updates #26

Open
annegentle opened this issue May 24, 2018 · 7 comments
Open

Needs Spark rename updates #26

annegentle opened this issue May 24, 2018 · 7 comments
Assignees

Comments

@annegentle
Copy link
Collaborator

Spark renamed to Webex Teams, and use ACCESS_TOKEN instead of SPARK_TOKEN - plus look for sparkbot.io renamed to webex.bot, and developer.ciscospark.com redirecting to developer.webex.com.

@annegentle
Copy link
Collaborator Author

Hey Ashley (@aroach ) I did the content changes in the devnet-express repo, but haven't circled back here. Can you take it?

@aroach
Copy link

aroach commented May 24, 2018

@annegentle are we only changing ACCESS_TOKEN -- looks like there are a lot of function names and variables with spark in them as well...

@annegentle
Copy link
Collaborator Author

Yeah I’m working towards removing Spark from variable names as well, using Webex or Webex Teams with matching capitalization or kebab-case as needed... see what you think of that as you dive in.

@annegentle
Copy link
Collaborator Author

See what you think of this PR for the DCI code: CiscoDevNet/devnet-express-dci-code-samples#6

@aroach
Copy link

aroach commented May 24, 2018

ok, what about filenames too? such as spark-room-easy.py

@annegentle
Copy link
Collaborator Author

That's what I'm working through today... trying to move those to webex-teams-room-easy.py for example. Will require testing, yeah.

@aroach
Copy link

aroach commented May 24, 2018

I think i got all of the changes except the meraki mission. See PR #27

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants