Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UI logic to support launch with 1 service only #170

Closed
anmipa opened this issue Nov 26, 2018 · 4 comments
Closed

Add UI logic to support launch with 1 service only #170

anmipa opened this issue Nov 26, 2018 · 4 comments
Assignees
Milestone

Comments

@anmipa
Copy link

anmipa commented Nov 26, 2018

It is possible that we launch with only one service connected to Omahelsinki.

This means that we need to refactor some components to know if there is only 1 service or several services connected to Omahelsinki. A lot of changes can be done in text, but there are some components that need work in code.

If only 1 service, this includes:
Landing page

  • front page -> hide "See all services" or something similar
  • services -> change "We have 4 services" to something else in text (not plural), or do this in some better way in code.

Mydata

  • if there is only 1 service and it is connected -> hide "Not yet connected services".

There might be other changes needed.

These are just suggestions, if you come up with better solutions, would be appreciated!

@anmipa anmipa added this to the Alpha 0.1 milestone Nov 26, 2018
@janimattiellonen janimattiellonen self-assigned this Nov 28, 2018
@janimattiellonen
Copy link
Contributor

Shouldn't we hide the "See all services" button on the landing page if there aren't more services available than what are listed on the landing page?

For example if we show 2 services and there are only 2 services then don't show the button?

@janimattiellonen
Copy link
Contributor

What is "to something else in text (not plural)"? :)

@anmipa
Copy link
Author

anmipa commented Nov 29, 2018

What is "to something else in text (not plural)"? :)

The current text "We have X services" is a bit silly in any case :) Something like "Oma.helsinki currently works with" would be better.

@janimattiellonen
Copy link
Contributor

Until we really do have something better, I wouldn't change the current "We have x services" :)

Imho, not sure if "Oma.helsinki currently works with" is better, but if you do, then I'll change it to that :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants