Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make device IDs based on MAC addresses #15

Closed
tcsullivan opened this issue Mar 15, 2024 · 2 comments · Fixed by #25
Closed

Make device IDs based on MAC addresses #15

tcsullivan opened this issue Mar 15, 2024 · 2 comments · Fixed by #25
Assignees
Labels
help wanted Extra attention is needed
Milestone

Comments

@tcsullivan
Copy link
Collaborator

We're leaning towards having device IDs be generated from the device's MAC address, meaning a physical device will always have the same ID. The server can coordinate the linking of IDs to users.

The UUID library we're using can be seeded so that its generation isn't truly random. At that point, we may not need to bother with storing the UUID in "EEPROM" either.

Maybe the UUID format is not even necessary? Is it bad to expose our MAC addresses? Might want some input from cybersecurity people on this...

@tcsullivan tcsullivan added the help wanted Extra attention is needed label Mar 15, 2024
@tcsullivan tcsullivan added this to the Beta milestone Mar 15, 2024
@tcsullivan
Copy link
Collaborator Author

We could generate our own IDs and permanently store them in eFuse memory. Would just need a tool/script to generate new IDs and make sure they are always unique.

@tcsullivan tcsullivan self-assigned this Mar 24, 2024
@tcsullivan
Copy link
Collaborator Author

I've made the device ID a UUID generated from the device's MAC address which should be okay to start with. Still need to confirm if we should burn custom IDs instead.

@tcsullivan tcsullivan linked a pull request Mar 31, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant