Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option --format for clickhouse-local should set both input and output formats. #30631

Closed
alexey-milovidov opened this issue Oct 25, 2021 · 6 comments · Fixed by #34352
Closed

Option --format for clickhouse-local should set both input and output formats. #30631

alexey-milovidov opened this issue Oct 25, 2021 · 6 comments · Fixed by #34352
Labels
easy task Good for first contributors unexpected behaviour usability

Comments

@alexey-milovidov
Copy link
Member

clickhouse-local can take three options: --input-format, --output-format and --format.
Currently the --format option only sets the output format.

Let's make it set default input and output formats that can be overriden by --input-format and --output-format.
@ghost
Copy link

ghost commented Nov 21, 2021

Wanna try it!

@alexey-milovidov
Copy link
Member Author

@Armenqaa Thank you, let's do it!

@alexey-milovidov
Copy link
Member Author

See ClientBase, Client and LocalServer h/cpp files.

@ghost
Copy link

ghost commented Nov 28, 2021 •
edited by ghost
Loading

Is insert-format https://github.com/ClickHouse/ClickHouse/blob/master/src/Client/ClientBase.h#L162 what we are looking for? @alexey-milovidov

@alexey-milovidov
Copy link
Member Author

@Armenqaa Yes, we should set both format and insert_format.

@alexey-milovidov alexey-milovidov unassigned ghost Jan 19, 2022
@alexey-milovidov
Copy link
Member Author

@Armenqaa Hi, how is it?

@taiyang-li taiyang-li mentioned this issue Feb 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
easy task Good for first contributors unexpected behaviour usability
Projects
None yet
Milestone
No milestone
1 participant
@alexey-milovidov