Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve context in mock error message #89

Closed
jjtt opened this issue Oct 11, 2023 · 0 comments
Closed

Improve context in mock error message #89

jjtt opened this issue Oct 11, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@jjtt
Copy link
Contributor

jjtt commented Oct 11, 2023

Trying to mock the db for a codebase that uses multiple inserters and it's a bit of a learning curve to figure out what needs to be done.

One small change that made things easier for me was just adding req to the panic message here:

https://github.com/loyd/clickhouse.rs/blob/cef34f73e71d4cd25446475390e9b3b3803f0a40/src/test/mock.rs#L62
@jjtt jjtt mentioned this issue Oct 23, 2023
Closed
@loyd loyd closed this as completed in 65829d3 Jul 16, 2024
@loyd loyd added the enhancement New feature or request label Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Include req in panic message for mock failures jjtt/clickhouse.rs
2 participants
@loyd @jjtt