Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starting from AKS 1.28 max_surge is set to 10% #51

Closed
cveld opened this issue Apr 16, 2024 · 1 comment
Closed

Starting from AKS 1.28 max_surge is set to 10% #51

cveld opened this issue Apr 16, 2024 · 1 comment
Assignees

Comments

@cveld
Copy link

cveld commented Apr 16, 2024

As per hashicorp/terraform-provider-azurerm#24020 since AKS 1.28 max_surge is set to 10% for the default node pool by default.

Currently the module always reports a change on the max_surge setting from 10% to NULL when left to the defaults.

Desired situation:
The module should default to max_surge 10%.

Considerations:
AKS 1.27 is an LTS version. For customers running the defaults they will see a one time max_surge change from NULL to 10%. This seems a reasonable change as in line with the general kubernetes guidance.

Potentially this could be fixed in a future version of the azurerm provider as well which renders this request for a module patch unnecessary.

@tovstcn tovstcn assigned tovstcn and unassigned tovstcn Jun 13, 2024
@dkooll dkooll self-assigned this Jun 21, 2024
@dkooll
Copy link
Contributor

dkooll commented Jun 21, 2024

This is a upstream provider or rest api issue. In collaboration with Carl decided to close this one.

@dkooll dkooll closed this as completed Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants