Skip to content
This repository has been archived by the owner on May 5, 2022. It is now read-only.

Add loop timing metrics #8

Closed
wants to merge 1 commit into from
Closed

Add loop timing metrics #8

wants to merge 1 commit into from

Conversation

sam-github
Copy link
Contributor

@sam-github sam-github commented Sep 7, 2017

Fix #6

@codecov-io
Copy link

codecov-io commented Sep 7, 2017

Codecov Report

Merging #8 into master will decrease coverage by 8.98%.
The diff coverage is 12.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #8      +/-   ##
==========================================
- Coverage   86.66%   77.68%   -8.99%     
==========================================
  Files           2        2              
  Lines         105      121      +16     
==========================================
+ Hits           91       94       +3     
- Misses         14       27      +13
Impacted Files Coverage Δ
lib/appmetrics-prometheus.js 77.5% <12.5%> (-9.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a47dd22...cd042da. Read the comment docs.

@seabaylea
Copy link
Member

Data exposed through through the endpoint to Prometheus needs to be one of the supported types: gauge, counter, histogram or summary and should follow the naming convention. Anything that is specific to the Node.js runtime should be labelled as nodejs_<type>, in this case nodejs_eventloop_

See here for information on metric types:
https://prometheus.io/docs/concepts/metric_types/

And here for more information on naming and units:
https://prometheus.io/docs/practices/naming/

@CLAassistant
Copy link

CLAassistant commented Jul 27, 2019

CLA assistant check
All committers have signed the CLA.

@sam-github sam-github closed this Mar 20, 2020
@sam-github sam-github deleted the loop-metrics branch March 20, 2020 18:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add loop metrics to Prometheus data
4 participants