Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring branch not building on netlify, we might need to upgrade to v2 netlify #34

Closed
sanandnarayan opened this issue Aug 16, 2018 · 4 comments

Comments

@sanandnarayan
Copy link
Member

the following error https://app.netlify.com/sites/serverless-gatsby/deploys/5b74be33b312741685de80c1

cannot read initial property of undefined

on further debugging leads to
gatsbyjs/gatsby#1846

where the solution is to upgrade gatsby. this feels like a very weird issue

@sanandnarayan sanandnarayan changed the title Refactoring branch not building on netlify, we might need to move to v2 Refactoring branch not building on netlify, we might need to upgrade to v2 netlify Aug 16, 2018
@prasanna1211
Copy link
Contributor

V2 is highly unstable at the start of the project. Additionally most of the plugins which we use are yet to support V2 / unstable at that time. I feel the bug is down to this (as per a comment in the issue)

pages or components that are called within other pages within the folder of pages, that is, inside the folder of pages you must only have the pages that are functional for gatsby, if any of those pages needs some components you must position them outside of the page folder, this resolve the issue for me

This was already a TODO which I planned for today (I had other issues with this point).

Before moving to V2 we must ensure that it is highly stable.

@sanandnarayan
Copy link
Member Author

@prasanna1211 thanks for the quick reply

@prasanna1211
Copy link
Contributor

@sanandnarayan Fixed your refactoring branch and pushed in #37 . We can close this issue if you feel it is fine.

@prasanna1211
Copy link
Contributor

Closing the issue since it is fixed in master now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants