You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
"setServerParameters" isn't the right term, Codeception's convention for this is "haveServerParameters".
It doesn't make sense to have two functions for this, one for a single parameter, and one for multiple. If the expected argument is an array, anybody knows immediately what to pass. So the existing haveServerParameter can be deprecated in favor of the new haveServerParameters.
Remaining question: Is the "Symfony BrowserKit" thing more of a bug or more of a feature?
If feature: Just pass the array along to Symfony's setServerParameters, and that's it.
If bug: foreach() over the array and use Symfony's setServerParameter.
The text was updated successfully, but these errors were encountered:
Just stumbled upon this while searching for a new name for
deleteHeader()
, see #22Current situation:
haveServerParameter('name', 'value')
uses Symfony'sClient::setServerParameter()
setServerParameters([])
uses Symfony'sClient::setServerParameters()
which sets'HTTP_USER_AGENT' => 'Symfony BrowserKit'
by default.I would say:
haveServerParameter
can be deprecated in favor of the newhaveServerParameters
.If feature: Just pass the array along to Symfony's
setServerParameters
, and that's it.If bug:
foreach()
over the array and use Symfony'ssetServerParameter
.The text was updated successfully, but these errors were encountered: