Not being able to edit the map

[HardeepAsrani]

In the latest version, once you make a map you can't edit it. @contactashish13

[HardeepAsrani]

PS: You also can't add new maps until you delete the old one.

[selul]

@contactashish13 it might be related to the latest changes maybe?

[HardeepAsrani]

The console error is something about "layers." And I see the Maps have a Section for layers which is empty. I guess we removed some feature?

[contactashish13]

@HardeepAsrani can you test #86? If this is for some customers site, can you tag me on HS as there might be other scenarios that need to be tested.

[HardeepAsrani]

@Codeinwp/admins Works.

[radu-themeisle]

@contactashish13 I gathered 3 issues submitted 2 days ago and refer to the 2.3 update:

1. maps are not loaded correctly and there's the error: TypeError: undefined is not an object (evaluating 'd.options.layer.importcsv') TypeError: undefined is not an object (evaluating 'd.options.layer.importcsv')
2. Users report that after creating 1 map the "Add New" button doesn't work
3. Users with several maps report that upon update they only see 1 map

One of them has deactivated all the plugins and still has the issue. I'll try to see if I can find a bit of time to test this and if your PR solves the issue.

[radu-themeisle]

@contactashish13 I was able to replicate my 3 reported issue and Hardeep's (adding a new map) and I can confirm #86 solves them.

Unfortunately, I noticed other issues:

• When viewing the maps you have to click "ok" twice to get rid of the Google notice (happens in the dashboard too): https://www.useloom.com/share/0195f68304dd4cd393e6a993a74da364
• Custom map style doesn't show in the library/front: Map edit; Maps library; front end
• Layers tab is empty (there should be an upsell): http://prntscr.com/n2q4t6
• Street view button is missing: http://prntscr.com/n2q867
• Zoom Control size doesn't work, I set this one to "small" but it's the same size as the default style (same thing for the "large" setting, but maybe large = default? ): http://prntscr.com/n2q9a3
• Other Controls also don't seem to work, I made a screen recording to show them all: https://www.useloom.com/share/edd815ee071b45b1880b4394b15046cc

[radu-themeisle]

@contactashish13 what's the status on this? Can we have a fix this week? We have another pro user reporting these issues: http://prntscr.com/n6fug7

https://secure.helpscout.net/conversation/793986123/182696?folderId=212385

[contactashish13]

@radu-themeisle It looks like you have not tested with a valid google map key that's why you are getting that popup. That popup is from google and its behavior is something we cannot do anything about. Can you please retest these with a valid key and let me know what you find?

[radu-themeisle]

@contactashish13 I tested with a valid API key and the map works without issues but I still can't add a new one or edit the one I just created, it just seems the controls are inactive.
I noticed some errors in the console, maybe it helps you: http://prntscr.com/ng5yrh
(sorry, just figured I didn't test the PR, but the current WP.org version)

So, after taking the correct version (#86) I can confirm again that the issues are resolved.