Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new onepage starter site content #4310

Merged
merged 6 commits into from
Oct 28, 2024
Merged

Conversation

girishpanchal30
Copy link
Contributor

Summary

I’ve added new default starter content from the onepage demo site.

Check before Pull Request is ready:

Closes https://github.com/Codeinwp/neve-pro-addon/issues/2846

@girishpanchal30 girishpanchal30 added the pr-checklist-skip Allow this Pull Request to skip checklist. label Oct 22, 2024
@selul selul requested review from abaicus and removed request for selul October 22, 2024 07:32
@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Oct 22, 2024
@pirate-bot
Copy link
Collaborator

pirate-bot commented Oct 22, 2024

Plugin build for 1a99405 is ready 🛎️!

Copy link
Collaborator

@abaicus abaicus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@girishpanchal30 At first sight, the added images total ~2.7MB. We should look into optimizing and resizing them as much as possible so we save space. Otherwise the code looks good.

@girishpanchal30
Copy link
Contributor Author

Thank you for your review, @abaicus! I've uploaded the optimized images.

@vytisbulkevicius
Copy link
Contributor

@girishpanchal30
Copy link
Contributor Author

@vytisbulkevicius I've fixed it with the latest commit.

@vytisbulkevicius
Copy link
Contributor

@girishpanchal30 can you also check other checks failing here? I tried to re-run but still see checks failing. Thanks

@girishpanchal30
Copy link
Contributor Author

@vytisbulkevicius I've resolved the E2E for customizer on sample-data test case error, and for PHP Tests / Theme Check, there are no errors showing when checked with the Theme Check plugin.
image

@vytisbulkevicius vytisbulkevicius merged commit 014c391 into development Oct 28, 2024
15 of 16 checks passed
@vytisbulkevicius vytisbulkevicius deleted the feat/2846 branch October 28, 2024 11:43
@pirate-bot
Copy link
Collaborator

🎉 This PR is included in version 3.8.12 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants