Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release #4311

Merged
merged 49 commits into from
Oct 29, 2024
Merged

Release #4311

merged 49 commits into from
Oct 29, 2024

Conversation

vytisbulkevicius
Copy link
Contributor

@vytisbulkevicius vytisbulkevicius commented Oct 28, 2024

  • Added a new starter site
  • Fixed PHP warning in template_parts.php
  • Fixed compatibility issue with the TranslatePress plugin
  • Fixed the plugin install issue on a multisite installation
  • Fixed lightbox issue with alignment control
  • Added support for a new custom layout magic tag current_single_content [PRO]
  • Added support for Messenger social media sharing [PRO]

pirate-bot and others added 30 commits August 14, 2024 14:37
Bumps [codeinwp/themeisle-sdk](https://github.com/Codeinwp/themeisle-sdk) from 3.3.28 to 3.3.32.
- [Release notes](https://github.com/Codeinwp/themeisle-sdk/releases)
- [Changelog](https://github.com/Codeinwp/themeisle-sdk/blob/master/CHANGELOG.md)
- [Commits](Codeinwp/themeisle-sdk@v3.3.28...v3.3.32)

---
updated-dependencies:
- dependency-name: codeinwp/themeisle-sdk
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
…t/codeinwp/themeisle-sdk-3.3.32

chore(deps): bump codeinwp/themeisle-sdk from 3.3.28 to 3.3.32
Added messenger social media support
Fixed compatibility issue TranslatePress plugin
Fixed the plugin install issue with multisite
Fixed PHP warning in template_parts.php
Fixed lightbox issue with alignment control
Fixed cover layout issue with CPT
Added new custom layout magic tag support
@vytisbulkevicius
Copy link
Contributor Author

@girishpanchal30, can you also take a look into conflicts in this final release before I merge?

@girishpanchal30
Copy link
Contributor

@vytisbulkevicius I don't see any conflict here, are you talking about the failed checklist?

@vytisbulkevicius
Copy link
Contributor Author

@girishpanchal30, sorry, yes I'm talking about the check failing

@girishpanchal30
Copy link
Contributor

@vytisbulkevicius I've rerun the E2E for woo-visual-regression on woo-sample, and it seems to have passed now. I'll look into the Build and Deploy StoryBook and let you know.

@girishpanchal30 girishpanchal30 mentioned this pull request Oct 28, 2024
6 tasks
@girishpanchal30
Copy link
Contributor

@vytisbulkevicius Can you please this PR into dev?

@vytisbulkevicius
Copy link
Contributor Author

merged @girishpanchal30

@girishpanchal30
Copy link
Contributor

@vytisbulkevicius For PHP Tests / Theme Check, I tested it locally, and it seems to be working fine. The issue might be with the GitHub Action setup.
https://github.com/Codeinwp/neve/actions/runs/11557420026/job/32167398164?pr=4311#step:5:27

@selul please let me know if you have a solution.

Thanks

@selul
Copy link
Contributor

selul commented Oct 29, 2024

@girishpanchal30 @vytisbulkevicius should be fixed now.

@selul
Copy link
Contributor

selul commented Oct 29, 2024

@girishpanchal30 the issue was related to a development file that was present in the SDK that was failing the theme-check.

@vytisbulkevicius vytisbulkevicius merged commit 3047736 into master Oct 29, 2024
16 checks passed
@pirate-bot
Copy link
Collaborator

🎉 This PR is included in version 3.8.12 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants