Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note beams sometimes overlap rest symbols #296

Closed
cheap-glitch opened this issue Dec 7, 2019 · 2 comments · Fixed by #491
Closed

Note beams sometimes overlap rest symbols #296

cheap-glitch opened this issue Dec 7, 2019 · 2 comments · Fixed by #491
Assignees
Labels
area-rendering Everything related to the rendering state-accepted This is a valid topic to work on. type-improvement 🚀

Comments

@cheap-glitch
Copy link

Your environment

  • Version used: latest (develop)
  • Platform used: JavaScript
  • Rendering engine used: SVG
  • Browser Name and Version: Firefox
  • Operating System and version (desktop or mobile): Linux desktop

Expected Results

Note beams should not overlap rests. Example in GP6:
screenshot-1575741833

Observed Results

There is a small visual bug in alphatab where the beams sometimes overlap the rests:
Screenshot_2019-12-07 The Guitar Lick Database

Steps to Reproduce (for bugs)

Create a tablature with two notes separated by a rest, e.g.:

15.2.16 r.8 12.3

Result:
Screenshot_2019-12-07 The Guitar Lick Database(1)

@Danielku15
Copy link
Member

AlphaTab has currently no mechanism for "collision detection" of music notation elements hence this would be rather a new feature / enhancement than a bug.

For rests it should be possible rather simple to avoid collisions compared to other areas like with slurs and ties.

@Danielku15 Danielku15 self-assigned this Dec 17, 2019
@Danielku15 Danielku15 added this to the 1.x milestone Dec 17, 2019
@Danielku15 Danielku15 added state-accepted This is a valid topic to work on. type-improvement 🚀 area-rendering Everything related to the rendering labels Dec 17, 2019
@Danielku15 Danielku15 removed this from the 1.x milestone May 7, 2020
@Danielku15 Danielku15 added this to the 1.2 milestone Jul 21, 2020
@Danielku15
Copy link
Member

Rests are now considered properly during beaming:
image

This was referenced Jan 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-rendering Everything related to the rendering state-accepted This is a valid topic to work on. type-improvement 🚀
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants