diff --git a/sandboxlib/load/appc.py b/sandboxlib/load/appc.py index fd1dd4c..e24eead 100644 --- a/sandboxlib/load/appc.py +++ b/sandboxlib/load/appc.py @@ -40,7 +40,26 @@ def unpack_app_container_image(image_file): try: # FIXME: you gotta be root, sorry. with tarfile.open(image_file, 'r') as tf: - tf.extractall(path=tempdir) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tf, path=tempdir) manifest_path = os.path.join(tempdir, 'manifest') rootfs_path = os.path.join(tempdir, 'rootfs')