Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Audio] Separate timeout for lavalink downloading #6460

Open
Chovin opened this issue Oct 2, 2024 · 0 comments · May be fixed by #6461
Open

[Audio] Separate timeout for lavalink downloading #6460

Chovin opened this issue Oct 2, 2024 · 0 comments · May be fixed by #6461
Labels
Status: Needs Triage This has not been labeled or discussed for handling yet. Type: Enhancement Something meant to enhance existing Red features.

Comments

@Chovin
Copy link

Chovin commented Oct 2, 2024

What component of Red (cog, command, API) would you like to see improvements on?

Audio

Describe the enhancement you're suggesting.

Currently there is a single timeout for the combined Lavalink downloading and starting up.

await self.managed_node_controller.start(java_exec)
# timeout is the same as ServerManager.timeout -
# 60s in case of ServerManager(self.config, timeout=60)
await self.managed_node_controller.wait_until_ready()

async def wait_until_ready(self, timeout: Optional[float] = None):
await asyncio.wait_for(self.ready.wait(), timeout=timeout or self.timeout)

It'd be nice if there was a separate timeout specifically for downloading so that those with slow connections can still use managed Lavalink

Anything else?

No response

@Chovin Chovin added the Type: Enhancement Something meant to enhance existing Red features. label Oct 2, 2024
@github-actions github-actions bot added the Status: Needs Triage This has not been labeled or discussed for handling yet. label Oct 2, 2024
@Chovin Chovin linked a pull request Oct 2, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Triage This has not been labeled or discussed for handling yet. Type: Enhancement Something meant to enhance existing Red features.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant