Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor functions to be smaller and more modular #25

Open
3 tasks
AliSajid opened this issue Oct 10, 2023 · 0 comments
Open
3 tasks

Refactor functions to be smaller and more modular #25

AliSajid opened this issue Oct 10, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@AliSajid
Copy link
Collaborator

AliSajid commented Oct 10, 2023

BiocCheck::BiocCheck() issues a NOTE for functions longer than 50 lines. Currently, 3 functions are longer than 50 lines. These functions should be refactored to be smaller and more modular.

The Note in question is:

* Checking function lengths...
    * NOTE: The recommended function length is 50 lines or less. There are 3 functions greater than 50 lines.

The functions in question are:

The Idea would be to encapsulate some of the logic that is common to these and other fucntions into unexported utility functions. This way, we can defer the error or check logic to these functions and keep the core functions more readable and concise.

@AliSajid AliSajid self-assigned this Oct 10, 2023
@AliSajid AliSajid added enhancement New feature or request good first issue Good for newcomers labels Oct 10, 2023
@AliSajid AliSajid added this to the Bioconductor-Resubmission milestone Feb 11, 2024
@AliSajid AliSajid added the help wanted Extra attention is needed label Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant