Sidepanel focus follows active report #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 19, 2018 12:56
michaldziubek
requested review from
mateuszluczak,
jakublamprecht,
edworczak,
wiiitek and
malaskowski
wiiitek
approved these changes
Feb 19, 2018
mateuszluczak
approved these changes
Feb 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The side panel focus follows now the currently opened report while navigating between them using [ ] keyboard shortcuts.
In addition, the unused mCustomScrollbar plugin was removed from source code.
Motivation and Context
There is functionality to navigate between test's urls using [ ] keys on keyboard.
Hovewer the sidepanel navigation did not follow the active report - the user had to scroll the Side panel manually in order to find the currently opened report.
Types of changes
Checklist:
I hereby agree to the terms of the AET Contributor License Agreement.