Save/Discard changes buttons cover bottom part of sidepanel Fix #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 26, 2018 15:05
szymon-owczarzak
approved these changes
Feb 26, 2018
CHANGELOG.md
Outdated
| @@ -10,6 +10,7 @@ All notable changes to AET will be documented in this file. | |||
| ## Unreleased | |||
| **List of changes that are finished but not yet released in any final version.** | |||
|
|
|||
| - [PR-230](https://github.com/Cognifide/aet/pull/230) Added fixing styles for side panel dimensioning when 'Save/Discard Changes' buttons are visible. | |||
There was a problem hiding this comment.
Consider better description like:
Bug Fixed: Side panel items not accessible when 'Save/Discard Changes' buttons are shown.
| <div class="js-rebase-all" ng-if="sidepanel.thereAreChangesToSave()" | ||
| ng-click="sidepanel.saveAllChanges()"> | ||
|
|
||
| <div class="js-manage-changes-wrapper" ng-if="sidepanel.thereAreChangesToSave()"> |
There was a problem hiding this comment.
Could we rename this class to something that doesn't have 'js' prefix and doesn't mention any funcitonality since we're not using it in any JS file?
There was a problem hiding this comment.
Class selector renamed
wiiitek
approved these changes
Feb 26, 2018
# Conflicts: # CHANGELOG.md # report/src/main/webapp/assets/css/main.css
…to save-discard-changes-buttons # Conflicts: # report/src/main/webapp/assets/css/main.css
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing styles for sidepanel dimensioning when 'Save/Discard Changes' buttons are visible.
Motivation and Context
When Save/Discard changes buttons are visible, they are covering the bottom part of side panel making test located there unable to be clicked. In this PR I am fixing this issue by adding proper styles.
Types of changes
I hereby agree to the terms of the AET Contributor License Agreement.