Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for grid #264

Merged
merged 7 commits into from
Jun 27, 2018
Merged

Prepare for grid #264

merged 7 commits into from
Jun 27, 2018

Conversation

wiiitek
Copy link
Contributor

@wiiitek wiiitek commented Jun 16, 2018

Description

Let's introduce a way to use different web driver than default.
This PR introduces changes for test to spoecify preferred browser ID.
This way we could have more than one WebDriver factories active. Usage example:

<test name="S-comparator-Layout" browser="chrome">
    ...

Motivation and Context

It enables us to work gradually on new web drivers (selenium grid).
We are still maintaining current way of usng Firefox 38.6 ESR

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

I hereby agree to the terms of the AET Contributor License Agreement.

Copy link
Contributor

@malaskowski malaskowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about renaming test parameter to browser?
I know the name webDriverId is more appropriate here from the technical perspective, but when we make changes in the AET suite DSL, it should be more user-friendly.

@malaskowski malaskowski merged commit 9f62c94 into master Jun 27, 2018
@malaskowski malaskowski deleted the prepare-for-grid branch June 27, 2018 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants