Added possibility to override name parameter from the aet client #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malaskowski
reviewed
Jun 29, 2018
There was a problem hiding this comment.
Thank you @mchrominski for this improvement.
Could you please update changelog? Please see more details in the AET contributing guide.
| @@ -56,6 +56,6 @@ The Root element for the xml definition, each test suite definition consists of | |||
| | `name` | Name of the test suite. It should contain lowercase letters, digits and/or characters: `-`, `_` only. | yes | | |||
| | `company` | Name of the company. It should contain lowercase letters, digits and/or characters: `-` only.| yes | | |||
| | `project` | Name of the project. It should contain lowercase letters, digits and/or characters: `-` only.| yes | | |||
| | `domain` | General domain name consistent for all urls considered. Every url link is built as a concatenation of the *domain* name and the *href* attribute of it. If the `domain` property is not set, then the `href` value in the `url` definition should contain a full valid url. See more in the [[Urls|Urls]] section. | no | | |||
| | `domain` | General domain name consistent for all urls considered. Every url link is built as a concatenation of the *domain* name and the *href* attribute of it. If the `domain` property is not set, then the `href` value in the `url` definition should contain a full valid url. See more in the [Urls](../Urls) section. | no | | |||
There was a problem hiding this comment.
That was ok, [[XX|XX]] is special wiki shortcut for doing markup link.
There was a problem hiding this comment.
Actually this syntax when used in tables breaks the formatting. See last row in https://github.com/Cognifide/aet/wiki/DefiningSuite
There was a problem hiding this comment.
Ok I see, in that case we can use another Wiki feature and do [[Urls]] instead.
mchrominski
changed the title
malaskowski
approved these changes
Jul 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable reusing suite descriptor files amongst different executions
Description
I enhanced aet-maven-plugin with the possibility to pass the overridden suite name value. This parameter is now consumable by the AET web API.
Motivation and Context
See #256
Types of changes
Checklist:
I hereby agree to the terms of the AET Contributor License Agreement.