Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#121] Shared Patterns - use latest patterns of given suite name #286

Merged
merged 4 commits into from
Jul 11, 2018

Conversation

tkaik
Copy link
Contributor

@tkaik tkaik commented Jul 11, 2018

Description

Currently the Shared Patterns feature requires full correlationId to use patterns from different suite. This Pull Requests adds a new parameter 'patternSuite' which only requires the suite name, whose latest version will be used as patterns source.

Motivation and Context

Fixes #121

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

I hereby agree to the terms of the AET Contributor License Agreement.

Shared Patterns - added new parameter 'patternSuite' which
only requires the suite name instead of full correlation ID
- updated maven client plugin
- updated documentation
@tkaik tkaik requested a review from malaskowski July 11, 2018 12:09
Updated CHANGELOG.md with created Pull Request
Copy link
Contributor

@malaskowski malaskowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic work @tkaik . Thank you for that, all unit tests and docs update.

@malaskowski malaskowski merged commit 2d5fa92 into master Jul 11, 2018
@malaskowski malaskowski deleted the feature/shared-patterns--latest-suite branch July 11, 2018 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SharedPatterns - take latest suite
3 participants