Util package should not be imported in ordinary qdarkstyle usage

[marcelomanzo]

Describe Your Environment

(srsvenv) C:\temp\srsvenv\Scripts>qdarkstyle --all

• OPERATING SYSTEM---------------------------------------------------------------
  • System........................ Windows
  • Release....................... 10
  • Platform...................... Windows-10-10.0.17763-SP0
  • Version....................... 10.0.17763
• PYTHON DISTRIBUTION------------------------------------------------------------
  • Version....................... 3.7.0
  • C Compiler.................... MSC v.1914 64 bit (AMD64)
  • C API Version................. 1013
  • Implementation................ cpython
  • Implementation Version........ 3.7.0
• QT BINDINGS--------------------------------------------------------------------
  • PySide2 Version............... 5.12.3
  • PySide2 Qt Version............ 5.12.3
• QT ABSTRACTIONS----------------------------------------------------------------
  • Status........................ No Qt abstractions available!
• PYTHON PACKAGES----------------------------------------------------------------
  • helpdev....................... 0.6.10

Language

[Python]

Description / Steps to Reproduce [if necessary]

Invoke:
app.setStyleSheet(qdarkstyle.load_stylesheet_pyside2())

Actual Result

File "C:\Users\marce\PycharmProjects\dashboard\gui\gui.py", line 86, in main
app.setStyleSheet(qdarkstyle.load_stylesheet_pyside2())
File "C:\temp\srsvenv\lib\site-packages\qdarkstyle_init_.py", line 355, in load_stylesheet_pyside2
return load_stylesheet(pyside=True)
File "C:\temp\srsvenv\lib\site-packages\qdarkstyle_init_.py", line 272, in load_stylesheet
from qdarkstyle.utils.scss import create_qss
File "C:\temp\srsvenv\lib\site-packages\qdarkstyle\utils\scss.py", line 24, in
from qdarkstyle.utils.images import create_images, create_palette_image
File "C:\temp\srsvenv\lib\site-packages\qdarkstyle\utils\images.py", line 14, in
from qtpy.QtCore import QSize
ModuleNotFoundError: No module named 'qtpy'

Expected Results / Proposed Result

[A description, output ou image of the expected/proposed result]

Relevant Code [if necessary]

[A piece of code to reproduce and/or fix this issue]

# code here to reproduce the problem

[ccordoba12]

ModuleNotFoundError: No module named 'qtpy'

You don't have qtpy installed, which is a dependency of QDarkstyle.

[marcelomanzo]

This is strange, why would I install pyqt if I'm using pyside2?
It wasn't like this 3 weeks ago.

[goanpeca]

qtpy != pyqt

https://pypi.org/project/QtPy/

[marcelomanzo]

ok, let me try

[marcelomanzo]

Now I get:

C:\temp\srsvenv\Scripts\python.exe C:/Users/marce/PycharmProjects/dashboard/main.py
Traceback (most recent call last):
  File "C:/Users/marce/PycharmProjects/dashboard/main.py", line 18, in <module>
    gui.gui.main()
  File "C:\Users\marce\PycharmProjects\dashboard\gui\gui.py", line 86, in main
    app.setStyleSheet(qdarkstyle.load_stylesheet_pyside2())
  File "C:\temp\srsvenv\lib\site-packages\qdarkstyle\__init__.py", line 355, in load_stylesheet_pyside2
    return load_stylesheet(pyside=True)
  File "C:\temp\srsvenv\lib\site-packages\qdarkstyle\__init__.py", line 273, in load_stylesheet
    create_qss()
  File "C:\temp\srsvenv\lib\site-packages\qdarkstyle\utils\scss.py", line 108, in create_qss
    _create_scss_variables(variables_scss_filepath, palette)
  File "C:\temp\srsvenv\lib\site-packages\qdarkstyle\utils\scss.py", line 82, in _create_scss_variables
    with open(variables_scss_filepath, 'w') as f:
FileNotFoundError: [Errno 2] No such file or directory: 'C:\\temp\\srsvenv\\lib\\site-packages\\qdarkstyle\\qss\\_variables.scss'

[ccordoba12]

@goanpeca?

[goanpeca]

@marcelomanzo what version of QDarkStyle are you using?

[marcelomanzo]

pip install git+git://github.com/ColinDuquesnoy/QDarkStyleSheet.git

[goanpeca]

Is there any reason why you are using master instead of doing:

pip install QDarkStyleSheet

?

(Aside of the fact that the error you see needs to be fixed of course)

[marcelomanzo]

I was checking if the #150 was fixed in the master but not in the repository.

[goanpeca]

@marcelomanzo You need to reinstall, since what you have does not seem to correspond to what is currently on master

https://github.com/ColinDuquesnoy/QDarkStyleSheet/tree/master/qdarkstyle

You are missing a bunch of folders...

[marcelomanzo]

ok, you can close, would you be able to re-open #150?

thanks

[dpizetta]

Hi @goanpeca @ccordoba12 May we have to not import from "util" in the init, as we have discussed that we'll still be producing the qss file to put in the repo, and at this moment qtpy is only needed for developers or for who wants to change something in the style. And remembering that to compile, people need to have other tools like uic/rcc that could depends on not only Python.

from __init__.py line 275

# Compiles SCSS/SASS files to QSS
    from qdarkstyle.utils.scss import create_qss
    create_qss()

[goanpeca]

@dpizetta sure, we can add those imports with try/except

If you can open an issue I can look at ti :-)

[dpizetta]

As the main problem in this issue as not about PySide2, I've changed the title, so we have a case of use. We should not create or compile things for ordinary usage, this should be explicit.

[dpizetta]

@goanpeca If you have not worked on it yet, I can make those changes :) Could you take a look in the current version on repo if they are ok with both example interface and spyder? So we can create a new release :) Tks

[goanpeca]

I am out right now, I can do it tomorrow! (sorry I forgot about this issue :-|, if you could work on it that would be great!

[dpizetta]

No problems, I take care!

[marcelomanzo]

it's working now, thanks!