Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Burning rubber is displayed in color even though the CPC is set to black and white #203

Open
cpcbegin opened this issue Apr 9, 2021 · 3 comments
Labels

Comments

@cpcbegin
Copy link

cpcbegin commented Apr 9, 2021

You can see on this video at this point.

I try the lastest code of april 9, 2021 compiled in GNU/Linux (Ubuntu Mate 20.04).

@ColinPitrat
Copy link
Owner

Interesting. I checked and this is an old bug, not introduced by the migration to SDL2.

@ColinPitrat
Copy link
Owner

The problem is that in asic.cpp, when we set the palette, we do not check CPC.scr_tube.
There's actually a TODO for it:

// TODO: deduplicate with code in video_set_palette + make it work in monochrome

@ColinPitrat
Copy link
Owner

The problem is that the Plus mode offers 4096 colors instead of just 32, so we need some generic code to convert the colors.
Fortunately, #135 provides just that.
Currently we support two green modes but with the Plus, we may have to force the libretro one ...
Or manage to find a formula that reproduces the original Caprice32 green mode.

@ColinPitrat ColinPitrat added the bug label Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants