Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load times of images #74

Open
tomsiebring opened this issue Feb 21, 2023 · 2 comments · May be fixed by #118
Open

Load times of images #74

tomsiebring opened this issue Feb 21, 2023 · 2 comments · May be fixed by #118
Labels
question Further information is requested

Comments

@tomsiebring
Copy link
Collaborator

Sometimes it takes very long for a hero image to load, especially on /steun-je-school, because there are a lot of images there. Could we make something such that images are only loaded when you scroll to it on the page? Instead of preloading everything at same time?
@dastrong
Copy link
Collaborator

The image masonry component uses the priority prop, when it shouldn't.

<Image
  key={image.src}
  priority    <-----
  src={image}
  alt="Actiefoto Image"
  className="rounded object-fit w-full"
  placeholder="blur"
/>

@CollActionOfficial
Copy link
Contributor

@dastrong so when we remove the priority prop from all images, including the heros, regular images and the masonry ones, it should get better?

@CollActionOfficial CollActionOfficial added the question Further information is requested label Apr 14, 2023
@ahung1709 ahung1709 linked a pull request Apr 29, 2023 that will close this issue
Fix/gh 74/amend image priority #118
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix/gh 74/amend image priority CollActionteam/collaction_website
3 participants
@dastrong @tomsiebring @CollActionOfficial