Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Document cannot be saved, please check your permissions" #9328

Open
techadmin-localbit opened this issue Jun 22, 2024 · 11 comments
Open

"Document cannot be saved, please check your permissions" #9328

techadmin-localbit opened this issue Jun 22, 2024 · 11 comments
Labels
24.04 bug Something isn't working unconfirmed

Comments

@techadmin-localbit
Copy link

Describe the Bug

If I share a document/folder like .odt or .ods with an external user by link. After you open the shared link and modify the document (with full write permissions), it shows you the following message: "Document cannot be saved, please check your permissions".
Even than, it saves the document.

Steps to Reproduce

  1. as Nextcloud user go to your folder you want share by link with external users.
  2. Click on Share button
  3. share link, add a password, with full write permissions
  4. use generated link in a different browser
  5. open your .ods file in the folder
  6. Change content and click on save button
  7. message: "Document cannot be saved, please check your permissions"

Expected Behavior

No error message, or save confirmation message

Actual Behavior

message: "Document cannot be saved, please check your permissions"

Screenshots

Screenshot from 2024-06-22 11-50-20

Desktop

  • Collabora version: [24.04.4.2]
  • OS and version: [Linux Debian 11]
  • Browser and version: [Chrome 125.0.6422.76]
  • Nextcloud: [28.0.6]
@thebearon
Copy link
Contributor

I've tried these exact steps, but have been unable to reproduce the issue. Is it consistently reproducible for you with the steps?

@techadmin-localbit
Copy link
Author

I missed one important information. I use "External storage", where the file is saved. Only in this combination do I have this problem, otherwise it is working.
I made some changes on the properties of "External storage", but no success.

@techadmin-localbit
Copy link
Author

When I check the logs on Nextcloud, I see the following error:

Uncaught error: Call to a member function getUID() on null in file '/var/www/nextcloud/lib/private/FilesMetadata/FilesMetadataManager.php' line 125"

If I comment the line 125 in the file FilesMetadataManager.php the error seems to be gone away:

//$this->jobList->add(UpdateSingleMetadata::class, [$node->getOwner()->getUID(), $node->getId()]);

I guess that it could be a problem when you are an external user that hasn't a specific UID, since the error only shows when you are an external user and not one in the LDAP.

@timur-g timur-g added the 24.04 label Jun 28, 2024
@jonasgarstick
Copy link

jonasgarstick commented Jul 9, 2024

We receive the same error messages for all guest users, even if they have the appropriate permissions.

  • Nextcloud v28.0.7
  • richdocuments v8.3.8
  • Collabora Online Development Edition 24.04.5.1 48bf0bf
  • guests v3.0.1

@mmeeks
Copy link
Contributor

mmeeks commented Jul 16, 2024

@juliushaertl Thoughts appreciated =) looks like an easy fix - superficially - thanks so much @jonasgarstick for the analysis & ticket !

@juliusknorr
Copy link
Member

We had a fix for this scenario for upcoming Nextcloud 30 with nextcloud/server#44294. I'll see if we can get a patch without the public API change backported.

@thebearon
Copy link
Contributor

@juliushaertl As I can see, the fix is part of 29.0.5, is that correct?

@juliusknorr
Copy link
Member

Yes

@tatrapikao
Copy link

tatrapikao commented Sep 5, 2024

This also affects group folders - will the fix work for this too?

@tatrapikao
Copy link

tatrapikao commented Sep 12, 2024

We now (NC 29.0.6 / COOLWSD 24.04.7.1) get the error also in some Folders that are shared from the same instance. This pretty much renders Collabora useless as the message appears on every autosave and makes it nearly impossible to edit the document.

Also it seems that not all group folders are affected. Those that have only one member (group or user) and don't use advanced permissions work fine. Also those with two members with different permission sets and no advanced permissions work fine. Group Folders that either use advanced permissions and or have two users or groups with identical permissions still throw the error.

@mmeeks
Copy link
Contributor

mmeeks commented Sep 12, 2024

@juliushaertl can we move this ticket to richdocuments somehow ? =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
24.04 bug Something isn't working unconfirmed
Projects
Status: No status
Development

No branches or pull requests

7 participants