Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue - This breaks ComfyUI-N-Sidebar custom node #140

Closed
RamonGuthrie opened this issue Jul 17, 2024 · 9 comments
Closed

Issue - This breaks ComfyUI-N-Sidebar custom node #140

RamonGuthrie opened this issue Jul 17, 2024 · 9 comments
Labels
bug Something isn't working

Comments

@RamonGuthrie
Copy link

The revamped search box breaks this node and https://github.com/Nuked88/ComfyUI-N-Sidebar Also Ctrl + B doesn't function

@huchenlei huchenlei added the bug Something isn't working label Jul 17, 2024
@huchenlei
Copy link
Member

Side bar features will be implemented natively here later this week.

@huchenlei
Copy link
Member

Actually it's not the search box breaking the side bar. It's the beta menu UI. If you use default menu UI it is fine for now.

There are some legacy issues on canvas resize.

@huchenlei
Copy link
Member

image
image

BTW, you can disable the revamped search box in settings.

@RamonGuthrie
Copy link
Author

Side bar features will be implemented natively here later this week.

This is great to hear are you/devs teaming up with the Devs of ComfyUI-N-Sidebar, or is this a different vision of what a Sidebar should be?

@RamonGuthrie
Copy link
Author

RamonGuthrie commented Jul 17, 2024

Actually it's not the search box breaking the side bar. It's the beta menu UI. If you use default menu UI it is fine for now.

There are some legacy issues on canvas resize.

I'm still getting a few issues, when I boot up ComfyUI I'm not sure if it's a conflict with https://github.com/11cafe/comfyui-workspace-manager which is a great very useful custom node extension

Here is an image of that error
image

And Ctrl + B doesn't work I can't use that shortcut to bypass nodes

This was referenced Jul 17, 2024
@huchenlei
Copy link
Member

Thanks for the info!

According to my test https://github.com/11cafe/comfyui-workspace-manager and https://github.com/Nuked88/ComfyUI-N-Sidebar together cause the canvas disappear issue. Enabling one of them seem to be fine.

@huchenlei
Copy link
Member

Merging into #136 as issues other than extension conflicts have been resolved.

@RamonGuthrie
Copy link
Author

RamonGuthrie commented Jul 19, 2024

Thanks for the info!

According to my test https://github.com/11cafe/comfyui-workspace-manager and https://github.com/Nuked88/ComfyUI-N-Sidebar together cause the canvas disappear issue. Enabling one of them seem to be fine.

There still seems to be an interface bug, with https://github.com/Nuked88/ComfyUI-N-Sidebar I have disabled https://github.com/11cafe/comfyui-workspace-manager in both tests

Without the command line argument --front-end-version Comfy-Org/ComfyUI_frontend@latest
image

With the command line argument --front-end-version Comfy-Org/ComfyUI_frontend@latest
image

@christian-byrne
Copy link
Collaborator

christian-byrne commented Jul 19, 2024

Thanks for the info!
According to my test https://github.com/11cafe/comfyui-workspace-manager and https://github.com/Nuked88/ComfyUI-N-Sidebar together cause the canvas disappear issue. Enabling one of them seem to be fine.

There still seems to be an interface bug, with https://github.com/Nuked88/ComfyUI-N-Sidebar I have disabled https://github.com/11cafe/comfyui-workspace-manager in both tests

Without the command line argument --front-end-version Comfy-Org/ComfyUI_frontend@latest image

With the command line argument --front-end-version Comfy-Org/ComfyUI_frontend@latest image

That issue appears to also happen on the legacy frontend if you change Font size setting in chrome://settings/appearance to Small. Height/width of that button is using rem sizing. The new frontend is just shifting the problem so that it occurs on Medium root font instead of Small, I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants