Update IconTintColorBehavior so it applies tint to Button image on Android and Windows like iOS and Mac Catalyst #2042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
2 tasks
|
Thanks @mikeparker104! Could you also update the sample app to add a reproduction of the problem being fixed? This way we'll have a regression test to ensure we don't accidentally break the functionality again. |
@brminnick updated sample app 👍 |
pictos
reviewed
Jul 19, 2024
...unityToolkit.Maui/Behaviors/PlatformBehaviors/IconTintColor/IconTintColorBehavior.windows.cs
Outdated
Show resolved
Hide resolved
|
/azp run |
|
Commenter does not have sufficient privileges for PR 2042 in repo CommunityToolkit/Maui |
brminnick
approved these changes
Jul 23, 2024
There was a problem hiding this comment.
Thanks @mikeparker104!!
Just FYI - we are working on fixing a bug in our CI pipeline that is not caused by this PR. Once the pipeline is fixed, we'll merge this PR ASAP.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Updated IconTintColorBehavior Android and Windows implementations so they apply the tint to Button images like on iOS and Mac Catalyst.
Linked Issues
PR Checklist
approved(bug) orChampioned(feature/proposal)mainat time of PRAdditional information
PR submitted as draft due to issue #2040 awaiting approved. AFAICT updates to existing documentation, tests, and samples are not required.