Removed spare Element checking in OnDetachedFrom #2132
Merged
+0
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Take look into
OnDetachedFrom()
We exiting when
Element
is null.The thing is that
Element
is always null because it returns aView
andbase.OnDetachedFrom()
callsUnassignViewAndBingingContext()
which sets it to null.Linked Issues
PR Checklist
approved
(bug) orChampioned
(feature/proposal)main
at time of PRSample code is not needed. You can check it using a
CommunityToolkit.Maui.Sample
by placing a breakpoint atTouchBehaviou.android.cs:76
(or somewhere else inOnDetachedFrom()
) and checking anElement
.Additional information