Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Base Version in azure-pipelines.yml #910

Closed
wants to merge 18 commits into from
Closed

Update Base Version in azure-pipelines.yml #910

wants to merge 18 commits into from

Conversation

twsl
Copy link

@twsl twsl commented Jan 19, 2023

Description of Change

This is a quick and dirty fix for the issue regarding the nightly versions by raising the semantic base version.

Linked Issues

PR Checklist

Additional information

@net-foundation-cla
Copy link

net-foundation-cla bot commented Jan 19, 2023

CLA assistant check
All CLA requirements met.

@brminnick
Copy link
Collaborator

brminnick commented Jan 19, 2023

Is there a way to automatically set its version number based on the version number of the latest release?

Otherwise, we will have the same problem after we release v4.0.0.

@bijington
Copy link
Contributor

git describe might get you some of the way there...

https://git-scm.com/docs/git-describe

Sadly I don't know how we would determine the type of change and ultimately the change in version component.

The best long term solution is to use a tool like GitVersion that just does it for us

@VladislavAntonyuk
Copy link
Collaborator

I think we can set the version number to 99.99.99.99, in that case it will always be a latest version, if user wants to use nightly builds

@brminnick
Copy link
Collaborator

I think we can set the version number to 99.99.99.99

Works for me!

@twsl
Copy link
Author

twsl commented Jan 19, 2023

as proposed in the discussion, ideally something like GitVersion would be used to automatically calculate the semver. Just using the same version number for everything might cause other problems in the future but could work for now

@VladislavAntonyuk
Copy link
Collaborator

as our next release is 4.0.0, let's for now use 4.1.0 and see how it works.
Ideally, we can use GitVersion as suggested.
I do not recommend use 99.0.0.00 in case somebody limits the latest version (>3.1.0 && <5.0.0)

@twsl
Copy link
Author

twsl commented Jan 29, 2023

Can someone else approve this so it gets merged?

@VladislavAntonyuk
Copy link
Collaborator

@brminnick, @jfversluis are you ok with the changes?

@brminnick
Copy link
Collaborator

brminnick commented Jan 29, 2023

If this is not urgent, I prefer that we implement a permanent solution that references the latest release number and works for both CommunityToolkit.Maui and CommunityToolkit.Maui.MediaElement.

This is a pretty low-effort PR that doesn't actually fix anything; it just delays the problem and creates more work for us in the future (we'll have to open a PR to bump this version number after every release).

@VladislavAntonyuk
Copy link
Collaborator

@twsl Could you please investigate how we can use GitVersion solution?

@twsl
Copy link
Author

twsl commented Jan 30, 2023

I can try, the issue with that is that I cannot test the azure pipelines locally

@VladislavAntonyuk
Copy link
Collaborator

@twsl don't worry about it. If the build passes, you can find the version number in the GitHub actions result:
image

@bijington
Copy link
Contributor

@twsl are you happy looking into the GitVersion approach? If not then I would be happy to help out

@twsl
Copy link
Author

twsl commented Jan 30, 2023

@bijington Feel free to tackle this. I did a quick test and just adding the nuget to the project causes issues and fails to build. Not sure if this requires GitTools/GitVersion#3334. Adding the azure pipelines task could also be a solution tho

@bijington
Copy link
Contributor

@bijington Feel free to tackle this. I did a quick test and just adding the nuget to the project causes issues and fails to build. Not sure if this requires GitTools/GitVersion#3334. Adding the azure pipelines task could also be a solution tho

Thanks for having a look. I'll look into that issue and hope that we can workaround it

@VladislavAntonyuk VladislavAntonyuk added the needs discussion Discuss it on the next Monthly standup label Feb 27, 2023
@ghost ghost added stale The author has not responded in over 30 days help wanted This proposal has been approved and is ready to be implemented labels Apr 2, 2023
@VladislavAntonyuk VladislavAntonyuk removed the needs discussion Discuss it on the next Monthly standup label Apr 2, 2023
@twsl
Copy link
Author

twsl commented May 10, 2023

@dotnet-policy-service agree

@bijington
Copy link
Contributor

@jfversluis this reminds me we need to have a chat about GitVersion

@twsl twsl closed this by deleting the head repository Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted This proposal has been approved and is ready to be implemented stale The author has not responded in over 30 days
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Wrong version for Nightly builds
4 participants