Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning up the repository #4026

Closed
5 tasks done
Nirmal4G opened this issue May 14, 2021 · 1 comment · Fixed by #4027
Closed
5 tasks done

Cleaning up the repository #4026

Nirmal4G opened this issue May 14, 2021 · 1 comment · Fixed by #4027
Labels
Completed 🔥 improvements ✨ optimization ☄ Performance or memory usage improvements
Milestone

Comments

@Nirmal4G
Copy link
Contributor

It's hard to read and understand the repo because of all the redundant files. It is also difficult to create PRs cleanly without introducing some sort of formatting change.
The following changes (although not exhaustive) would improve the contribution experience a little bit better.

  • Remove un-used, un-necessary and duplicate files
  • Clean-up trailing white-spaces and new-lines
  • Use Unicode charset without the BOM
  • Remove redundant xml meta-tag
  • Fix indentation on switch-case

I hope, these changes, along with the upcoming clean-up #3896 and refactoring #3898 would definitely make this repo better for everyone.

@ghost ghost added the needs triage 🔍 label May 14, 2021
@ghost
Copy link

ghost commented May 14, 2021

Hello Nirmal4G, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will analyze and investigate the issue, and escalate it to the relevant team if possible. Other community members may also look into the issue and provide feedback 🙌

@ghost ghost added the In-PR 🚀 label May 14, 2021
@Kyaa-dost Kyaa-dost added improvements ✨ optimization ☄ Performance or memory usage improvements and removed needs triage 🔍 labels May 14, 2021
@Kyaa-dost Kyaa-dost added this to the 7.1 milestone May 14, 2021
@ghost ghost added Completed 🔥 and removed In-PR 🚀 labels May 17, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Nov 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Completed 🔥 improvements ✨ optimization ☄ Performance or memory usage improvements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants