Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make use of .NET 7's new Nullable.GetValueRefOrDefaultRef() #498

Closed
rickbrew opened this issue Nov 14, 2022 · 0 comments · Fixed by #499
Closed

Make use of .NET 7's new Nullable.GetValueRefOrDefaultRef() #498

rickbrew opened this issue Nov 14, 2022 · 0 comments · Fixed by #499
Labels
feature request 📬 A request for new changes to improve functionality

Comments

@rickbrew
Copy link

Overview

NullableExtensions is still doing some rather sus stuff with Unsafe.As<>(). I think that can be migrated to use Nullable.GetValueRefOrDefaultRef() now. dotnet/runtime#64677

API breakdown

In NullableExtensions, remove RawNullableData<T> and rewrite the extensions to use Nullable.GetValueRefOrDefaultRef()

Usage example

...

Breaking change?

No

Alternatives

...

Additional context

No response

Help us help you

No, just wanted to propose this
@rickbrew rickbrew added the feature request 📬 A request for new changes to improve functionality label Nov 14, 2022
@Sergio0694 Sergio0694 mentioned this issue Nov 15, 2022
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request 📬 A request for new changes to improve functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use Nullable.GetValueRefOrDefaultRef where possible CommunityToolkit/dotnet
1 participant
@rickbrew