Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Our Wasm validator does not adhere to recent changes in Wasm specification. #331

Closed
abizjak opened this issue Mar 2, 2023 · 1 comment · Fixed by Concordium/concordium-node#913 or #398
Closed

Our Wasm validator does not adhere to recent changes in Wasm specification. #331

abizjak opened this issue Mar 2, 2023 · 1 comment · Fixed by Concordium/concordium-node#913 or #398
Assignees
@abizjak
Labels
[Type] Bug Something isn't working [Type] Change Request Some visible functionality should be change.

Comments

@abizjak
Copy link
Contributor

abizjak commented Mar 2, 2023

Specifically in WebAssembly/spec#1525 they restricted the appearance of globals in data and element sections (their initializers).

In the standard that we implemented https://www.w3.org/TR/2019/REC-wasm-core-1-20191205/#modules%E2%91%A3 this was allowed, and we adhere to the specification as stated there.

The discussion in WebAssembly/spec#1522 indicates that they consider this a typo in the specification.

We need to figure out what we should do. Consider this a bug or keep it.

If we were to fix it this requires a protocol update since it changes criteria for validity of smart contracts.
@abizjak abizjak added [Type] Bug Something isn't working [Type] Change Request Some visible functionality should be change. labels Mar 2, 2023
@abizjak
Copy link
Contributor Author

abizjak commented Jun 7, 2023

We will adhere to the updated standard in P6.

@abizjak abizjak self-assigned this Jun 21, 2023
This was referenced Jun 21, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abizjak abizjak

Labels
[Type] Bug Something isn't working [Type] Change Request Some visible functionality should be change.
Projects
None yet
Milestone
No milestone
1 participant
@abizjak