From ba6e2613e96e74fe3483b8a5bd7613417e9e905d Mon Sep 17 00:00:00 2001 From: Mike Lock Date: Thu, 27 Feb 2020 12:54:44 -0700 Subject: [PATCH 1/3] Remove PropTypes on Heading spread from removed Text import --- src/Heading/index.js | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/Heading/index.js b/src/Heading/index.js index 6a68429a..c1a07ad2 100644 --- a/src/Heading/index.js +++ b/src/Heading/index.js @@ -15,10 +15,6 @@ Heading.defaultProps = { fontSize: '', } -Heading.propTypes = { - ...Text.propTypes, -} - Heading.displayName = 'Heading' // H1 From df8f64c526a8e78a265981c27d2b5c1fc42d4ef7 Mon Sep 17 00:00:00 2001 From: Mike Lock Date: Thu, 27 Feb 2020 13:06:37 -0700 Subject: [PATCH 2/3] Add back PropTypes that are same as Text. --- src/Heading/index.js | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/Heading/index.js b/src/Heading/index.js index c1a07ad2..279e5091 100644 --- a/src/Heading/index.js +++ b/src/Heading/index.js @@ -1,6 +1,7 @@ import React from 'react' import PropTypes from 'prop-types' import Box from '../Box' +import theme from '../theme' const defaultProps = { fontWeight: 3, @@ -13,6 +14,12 @@ Heading.defaultProps = { ...defaultProps, as: 'h2', fontSize: '', + theme, +} + +Heading.propTypes = { + ...Box.propTypes, + theme: PropTypes.object, } Heading.displayName = 'Heading' From 18a82c7b44d8e3ab0f21a098d17ac00c12ea4946 Mon Sep 17 00:00:00 2001 From: Mike Lock Date: Thu, 27 Feb 2020 13:58:04 -0700 Subject: [PATCH 3/3] Version bump to 0.13.1 --- README.md | 8 +++++++- package.json | 2 +- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index f5f33c41..0fc4fbfb 100644 --- a/README.md +++ b/README.md @@ -35,6 +35,12 @@ class Example extends Component { ## Change log +### 0.13.1 + +🐛 Bug Fix + +- Added default props for `Heading` component. + ### 0.13.0 🚀 New Feature @@ -43,7 +49,7 @@ class Example extends Component { 🐛 Bug Fix -- Fixed `Heading` component `as` prop not working. +- Fixed `Heading` component `as` prop not working. - Fixed `Text` component `as` prop not working. - Fixed `Select` component arrow icon placement. diff --git a/package.json b/package.json index a3084c75..e0610be7 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "rimble-ui", - "version": "0.13.0", + "version": "0.13.1", "description": "Rimble Design System react component library.", "author": "ConsenSys Design", "homepage": "https://rimble.consensys.design/",