-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Icon display prop not honored #380
Comments
@MikeLockz The example for this bug shows an button and no icons and the tooltip appears to be working correctly. |
@gesquinca - Updated the failing example. Also happening in the demo app in the rimble-ui repo. |
@MikeLockz I'm still only seeing a Button and a Tooltip that seems to be attaching fine on this link. https://codesandbox.io/embed/tooltip-not-attached-to-icon-erzjo Anyhow, the tooltip is placed relatively to the element it wraps. If the element spans the length of the screen, like something with |
Figured out that I can't click the link and edit those sandboxes either. I need to login first 🤦♂️ Figured that out and updated the examples. https://codesandbox.io/s/tooltip-not-attached-to-icon-erzjo?from-embed It's happening to our live docs too so I think it's worth figuring out a solution for this that doesn't show a floating tooltip on the Icon. https://rimble.consensys.design/components/rimble-ui/Tooltip#examples I didn't realize that Icon has its display defaulted to 'block'. I tried to add a prop value like Checked the source and I think wrapping the Icon in the div is causing the display prop to not create an inline element out of the Icon. I don't think this is an issue with the Tooltip, but with Icon. How would we create an inline Icon, other than wrapping in a Box or using Flex? If the
I think this is where Icon was at one point. Not sure why it changed to a div from a Box as a wrapper around RmdIcon.default. |
Describe the bug
When Tooltip wraps an Icon, the Tooltip does not show attached to Icon
To Reproduce
Steps to reproduce the behavior:
https://codesandbox.io/embed/tooltip-not-attached-to-icon-erzjo
Expected behavior
Tooltip should appear next to Icon
Screenshots
If applicable, add screenshots to help explain your problem.
Rimble UI Version
The text was updated successfully, but these errors were encountered: