Add VKK parameter to marshall logic of BN254 mpcsetup phase2Evaluations #1137
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1136
vkey has a parameter "G1.K" that directly comes from the "G1.VKK" parameter of a Phase2Evaluations. However, Phase2Evaluations's marshalling code lacks this parameter, and this causes vkey to have "G1.K" as an empty list.
Eventually, a proof generated by outputted pkey can't be verified with the outputted vkey.
Type of change
How has this been tested?
Simply conduct a multi-party phase2 ceremony locally. At the end of each step (initialize, contribute, verify), save the created artifacts into files.
Finally, call ExtractKeys with the phase2Evaluations that you read from fs and you'll realize that the created vKey has its "G1.K" parameter as an empty list.
Checklist:
golangci-lint
does not output errors locally