Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: utility methods #1259

Open
ivokub opened this issue Aug 26, 2024 · 0 comments
Open

refactor: utility methods #1259

ivokub opened this issue Aug 26, 2024 · 0 comments
Assignees
Labels
cleanup consolidate strengthen an existing feature

Comments

@ivokub
Copy link
Collaborator

ivokub commented Aug 26, 2024

In #1258 I moved utility methods to internal packages as they seemed not to be useful outside of using gnark directly, but actually there were used downstream in zkevm-monorepo. Due to that, @Tabaie had to duplicate some of the functionality there.

But there are actually many utility methods used there which imo live better in gnark repository. I think we can add a github.com/consensys/gnark/utility package with the following subpackages etc:

  • algo_utils - sorting etc. used in GKR packages
  • circuit_utils - for utility methods which can be used inside the circuits (PLONK eval etc.)
  • witness_utils - for more convenient witness assignment which maps from *big.Int etc to frontend.Variable etc

We should also refactor the methods from the zkevm-monorepo which make sense.

@ivokub ivokub added cleanup consolidate strengthen an existing feature labels Aug 26, 2024
@ivokub ivokub self-assigned this Aug 26, 2024
@Consensys Consensys deleted a comment Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup consolidate strengthen an existing feature
Projects
None yet
Development

No branches or pull requests

1 participant