Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: commitment info is not (de)serialised with Groth16 verifying key and proofs. #580

Open
ivokub opened this issue Mar 16, 2023 · 0 comments
Open

bug: commitment info is not (de)serialised with Groth16 verifying key and proofs. #580

ivokub opened this issue Mar 16, 2023 · 0 comments
Labels
bug Something isn't working zk-evm
Milestone
v0.9.0

Comments

@ivokub
Copy link
Collaborator

ivokub commented Mar 16, 2023 •
edited
Loading

To track more issues with commitment serialisation here.

I think that right now the structs are not ideal. VerifyingKey contains a lot more data than it minimally should. I think it would be better to split the commitment info into minimal parts included correspondingly in proving and verifying key as needed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working zk-evm
Projects
None yet
Milestone
v0.9.0
Development

No branches or pull requests
2 participants
@ivokub @gbotrel