Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow eth_sendRawPrivateTransaction interceptor to use alias in privateFor #388

Closed
Tracked by #148
dolanor opened this issue Oct 15, 2021 · 2 comments
Closed
Tracked by #148

Allow eth_sendRawPrivateTransaction interceptor to use alias in privateFor #388

dolanor opened this issue Oct 15, 2021 · 2 comments
Assignees
@dolanor

Comments

@dolanor
Copy link
Contributor

dolanor commented Oct 15, 2021

No description provided.

@dolanor dolanor mentioned this issue Oct 15, 2021
Closed
10 tasks
@dolanor dolanor self-assigned this Oct 15, 2021
@dolanor
Copy link
Contributor Author

dolanor commented Oct 18, 2021

Fixed by 49c1e76

@dolanor dolanor closed this as completed Oct 18, 2021
@dolanor
Copy link
Contributor Author

dolanor commented Oct 20, 2021

Actually, it's not fixed by 49c1e76. We should have had a node interceptor that would handle eth_sendRawPrivateTransaction, but it's pointless in the case of aliases because the raw transaction is completely ready to pass to the node. Every alias parsing should be ahead of signing and sending this transaction.

The handling of the eth_sendRawPrivateTransaction is tracked in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dolanor dolanor

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dolanor