-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to geth 1.9.1 or newer #890
Comments
Hi @petermetz I have tried your JSON RPC request directly on both current master and v2.3.0 through WebSocket. It is working fine and the contract is successfully deployed. Can you share the web3.js script you are using which reproduces this error together with web3.js version? |
Hi @zzy96 Here's the file that instantiates Web3 https://github.com/hyperledger-labs/blockchain-integration-framework/blob/master/examples/simple-asset-transfer/quorum/api/utils/web3.js Here's the top level script that deploys the contract (with mentioned Web3 instance) The file that instantiates the Web3 contract object: And for reference here's a docker-compose file used to bring up the network itself (mostly your 7nodes example but were cut down to 4 nodes): If this doesn't help either, of course I can put together a small, self contained example, I was just trying to avoid that on account of other issues corroborating mine from ethereum-go that they already acknowledged as a problem. I mean mostly this one: ethereum/go-ethereum#19001 |
Unfortunately, I am not able to reproduce the issue. It would be helpful if you could provide a self-contained script to crash WebSocket. We will work on a patch if it is necessary. I understand that the upstream geth has used a new WebSocket library since 1.9.1. Geth upgrade for Quorum to 1.9.x is also ongoing 😃 |
That's fair enough @zzy96 . If the geth upgrade is already underway then I'll just have my fingers crossed that it will fix it and in the meantime we'll use the HTTP Web3 Provider and be done with it. |
System information
Geth version:
geth version
OS & Version: Windows/Linux/OSX
Ubuntu 18.04
Branch, Commit Hash or Release:
git status
Tried
2.2.5
and2.3.0
Cannot downgrade to any older versions because of the gas limit bug in 2.2.3 that breaks other things.
Expected behaviour
Contract deployment works.
Actual behaviour
Contract deployment is broken because geth shuts down the WebSocket connection, assuming that it does so due to ethereum/go-ethereum#19001
Steps to reproduce the behaviour
solc
)Specific contract I'm deploying: https://github.com/hyperledger-labs/blockchain-integration-framework/blob/master/examples/simple-asset-transfer/quorum/contracts/Root.sol
Potentially Relevant Issues
ethereum/go-ethereum#16846
web3/web3.js#1631
web3/web3.js#1217 (comment)
Backtrace
The exact JSON RPC request payload is 62390 bytes long and is pasted below:
Which then produces the WebSocket connection shut down in response:
The text was updated successfully, but these errors were encountered: