Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merge] Only subscribe to block gossip during optimistic sync #4784

Closed
ajsutton opened this issue Dec 12, 2021 · 0 comments
Closed

[Merge] Only subscribe to block gossip during optimistic sync #4784

ajsutton opened this issue Dec 12, 2021 · 0 comments
Assignees

Comments

@ajsutton
Copy link
Contributor

ajsutton commented Dec 12, 2021

Description

When optimistic sync is enabled, Teku should ensure it is not subscribed to any gossip except the block gossip topic. Other topics require the block to be fully validated so we are unable to forward gossip while optimistically syncing and would risk being downscored if we stayed subscribed.

On the initial startup, teku only enables gossip once the head block is close enough to the current slot to avoid this same problem because we haven't yet processed blocks. This check needs to be changed to use the optimistic head to enable gossip, but then only subscribe to the block channel until our head block is verified.

@ajsutton ajsutton changed the title [Merge] Use optimistic head to decide when to enable gossip [Merge] Only subscribe to block gossip during optimistic sync Jan 17, 2022
@ajsutton ajsutton self-assigned this Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant