Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit test fail in AzureVaultKeyGeneratorTest when build with linux file system #525

Closed
namtruong opened this issue Nov 15, 2018 · 2 comments
Closed

Unit test fail in AzureVaultKeyGeneratorTest when build with linux file system #525

namtruong opened this issue Nov 15, 2018 · 2 comments
Assignees
@namtruong
Labels
0.7 enhancement Non-user code enhancements

Comments

@namtruong
Copy link
Collaborator

This unit test exceptionThrownIfDisallowedCharactersUsedInVaultId expects java.nio.charset.UnsupportedCharsetException to be thrown however before that, Paths.get(filename) would attempt to use FileSystems.getDefault() to validate the file path, and this might return different outcomes depending on the OS system Tessera is being built in. In OS such as linux this method in Paths library will throw a different exception (java.nio.file.InvalidPathException) - causing the unit test to fail
@namtruong namtruong mentioned this issue Nov 15, 2018
Closed
@Krish1979 Krish1979 assigned Krish1979 and namtruong and unassigned Krish1979 Nov 15, 2018
@Krish1979 Krish1979 added enhancement Non-user code enhancements 0.7 labels Nov 15, 2018
@namtruong
Copy link
Collaborator Author

Fixed by #527

@Krish1979
Copy link
Collaborator

Fixed in 0.7.3 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@namtruong namtruong

Labels
0.7 enhancement Non-user code enhancements
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@namtruong @Krish1979