Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with From a Schema to an Attestation -- Broken build? #8

Open
mapachurro opened this issue Nov 6, 2024 · 2 comments
Open

Issues with From a Schema to an Attestation -- Broken build? #8

mapachurro opened this issue Nov 6, 2024 · 2 comments

Comments

@mapachurro
Copy link

mapachurro commented Nov 6, 2024

Overall, this tutorial does a good job of going step-by-step.

Broken and should be fixed:

The link to the code on github in this line gives you a 404:

image

It looks like something broke there on March 23rd, and maybe never got fixed:

image

Would be nice

When you're walking a user through a "hello world" example like this, where you're giving them one piece of the code at a time, it's good to show them what the whole thing looks like at the end.

In this tutorial, which is an "end to end walkthrough", I would suggest having one "finished script" that is functional and creates / registers a schema, and if it's appropriate / if that's how it works, creating a portal -- and then, a second script showing at the end that shows e.g. "how can I create an attestation, implemented in JS that I can copy paste into my web app UI for users to be able to make an attestation"

@mapachurro
Copy link
Author

@alainncls, @orbmis 🫡

@alainncls
Copy link
Collaborator

Hey @mapachurro 👋

I've fixed the link to the Tutorial repository (that we extracted from the main monorepo to a dedicated repo for clarity). Here's the commit and here's the working link.

And thanks for your suggestions!
From what I can see, we should do 2 things:

  1. Split the tutorial into 2 tutorials:
    1. a 'frontend' tutorial (basically what we have today)
    2. a 'backend' tutorial to tackle the 'script' scenario
  2. Rework the tutorial a bit, to show the final code

That is 100% doable! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants