Add --sort-commits-by-date option #97
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
reviewed
Mar 4, 2019
| @@ -37,6 +39,7 @@ Options: | |||
| --tag-pattern [regex] # override regex pattern for release tags | |||
| --tag-prefix [prefix] # prefix used in version tags, default: v | |||
| --starting-commit [hash] # starting commit to use for changelog generation | |||
| --sort-commits-by-date # sort commits by date (descending) instead of sorting by relevance | |||
There was a problem hiding this comment.
Maybe this would be better as a generic option that took a value of “date“, for extensibility?
There was a problem hiding this comment.
Thanks for the quick review! Yeah, that makes sense. I have no time to do it now though. Feel free to suggest an edit or commit yourself or whatever :)
There was a problem hiding this comment.
Yeah a generic --sort-commits sounds good. I'll give it a shot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an option
--sort-commits-by-dateoption, and adds an extra explanation to README.Fixes #95.