-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Kaltura's HTML5 player (v2) #1082
Conversation
Hi @cookpete, First of all, a very useful project, well done:) Thanks, |
Hi @jessp01, sorry for how long it has taken to get back to you on this. I'm running it locally and not much is working. Pause doesn't work, seeking doesn't work, volume change only works when you set it to The player API docs also don’t mention anything about supporting |
Hi @cookpete, Thanks for getting back to me. When you say you're running it locally, do you mean with the demo app (src/demo/App.js)? As for the documentation, indeed, it is lacking in that sense. The Kaltura player supports multiple embed methods and has its own API but when embedding in an Thanks again, |
Hi @cookpete , All basic APIs work now (tested using the demo app). If you feel it's important, I can implement the speed increase actions as well. Let me know if this can be merged? Cheers, |
I think something must be broken with their player API? Things still aren't working for me. Even the most basic interactive embed code (copied directly from their docs) doesn’t seem to work: http://player.kaltura.com/modules/PlayersJsReceiver/tests/PlayersJsReceiver.qunit.html var player = new playerjs.Player( document.getElementById('kaltura_player') );
//listen to play start
player.on(playerjs.Events.PLAY, function() {
// This is never called :(
console.log('play');
}); Live example: https://jsfiddle.net/zes7n2pw/ |
There’s also this page that has a script tag that doesn't work: https://developer.kaltura.com/player/web/getting-started-web <script type="text/javascript" src="https://cdnapisec.kaltura.com/p/000000/embedPlaykitJs/uiconf_id/22222222"></script> I get a 404 when I try the example as well as replace the conf_id and partner id with the ones from your sample URL: |
Hi @cookpete , Yes, I am aware of the fact that this demo (http://player.kaltura.com/modules/PlayersJsReceiver/tests/PlayersJsReceiver.qunit.html) does not work. I will try to get that fixed (not under my direct remit but I'll speak to the relevant people). Also, here's a standalone demo that works as well: The documentation you referenced (https://developer.kaltura.com/player/web/getting-started-web) pertains to Kaltura's player v7 (aka playKit). That's a completely different codebase I'm afraid (I agree it is confusing). I'll submit a pull to support that a bit later in the game, when it's a bit more mature. Thanks again for your time, |
Added some tweaks and fixes, mainly around the |
Hi @cookpete, Excellent. Thanks again for your time :) |
@cookpete - would it be possible for you to create a new release version? |
Would like to get some other stuff in first. Will publish soon 👍 |
Cheers, @cookpete. Much appreciated. |
Fixes cookpete#1202 and related to cookpete#1082.
* Adjust listener for kaltura Fixes #1202 and related to #1082. * Fix lint As mentioned in #1225 `findDOMNode` is deprecated. * Add autoplay to iframe props * Move code to load method and call it instead * Update src/players/Kaltura.js Co-authored-by: Pete Cook <pete@cookpete.com> * Remove `this.load()` call in `componentDidMount` Co-authored-by: Pete Cook <pete@cookpete.com>
This pull adds support for Kaltura player embeds (using an
iframe
tag).Thanks in advance for your consideration,