Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to react 15 #56

Closed
primeminister opened this issue Apr 18, 2016 · 7 comments
Closed

Upgrade to react 15 #56

primeminister opened this issue Apr 18, 2016 · 7 comments

Comments

@primeminister
Copy link

Hi, Would be nice if the react-player will also require 15.0.1 (at the time of writing) and not depend only on 0.14.
Thanks!

@cookpete
Copy link
Owner

I have upgraded to latest React locally and I've had to fix a couple of issues that came up. I also wasn't sure what to do about peerDependencies to prevent warning for people who want to remain on 0.14.0. For now I've used "react": "^15.0.1 || ^0.14.0" which hopefully does the job. I suppose "react": "*" would work too, like karma-mocha does with mocha.

@primeminister
Copy link
Author

ah ok! That is indeed the best way. So is that already in 0.5.7 version of react-player?

@cookpete
Copy link
Owner

So is that already in 0.5.7 version of react-player?

Nope, I haven't pushed that yet. I want to make sure everything works ok, and I'm rejigging some of the test structure while I'm at it. Once I'm happy I'll push 0.5.8, or maybe 0.6.0 because of all the dependency changes.

@primeminister
Copy link
Author

Nice work man! Let me know if I can help you with something on my fork.

@cookpete
Copy link
Owner

0.5.8 has been published 👍

@primeminister
Copy link
Author

WoW! 👍 That was quick and Thanks!

@cookpete
Copy link
Owner

I couldn't see any more problems, and I didn't want to sit on it for too long ;)

david-hub024 pushed a commit to david-hub024/React_VideoPlayer that referenced this issue Dec 23, 2018
Use `*` for react peer dependency to retain backward compatibility
Resolves cookpete/react-player#56
david-hub024 pushed a commit to david-hub024/React_VideoPlayer that referenced this issue May 23, 2020
Use `*` for react peer dependency to retain backward compatibility
Resolves cookpete/react-player#56
albanqoku added a commit to albanqoku/react-player that referenced this issue Feb 24, 2021
Use `*` for react peer dependency to retain backward compatibility
Resolves cookpete/react-player#56
Webmaster1116 added a commit to Webmaster1116/video-player that referenced this issue May 20, 2021
Use `*` for react peer dependency to retain backward compatibility
Resolves cookpete/react-player#56
webmiraclepro added a commit to webmiraclepro/video-player that referenced this issue Sep 9, 2022
Use `*` for react peer dependency to retain backward compatibility
Resolves cookpete/react-player#56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants