-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Double inline styles applied for Vimeo player #609
Comments
I did not check to see if any other player is also affected |
albanqoku
added a commit
to albanqoku/react-player
that referenced
this issue
Feb 24, 2021
albanqoku
added a commit
to albanqoku/react-player
that referenced
this issue
Feb 24, 2021
Introduced by cookpete/react-player#609 Fixes cookpete/react-player#675
Webmaster1116
added a commit
to Webmaster1116/video-player
that referenced
this issue
May 20, 2021
Webmaster1116
added a commit
to Webmaster1116/video-player
that referenced
this issue
May 20, 2021
Introduced by cookpete/react-player#609 Fixes cookpete/react-player#675
webmiraclepro
added a commit
to webmiraclepro/video-player
that referenced
this issue
Sep 9, 2022
webmiraclepro
added a commit
to webmiraclepro/video-player
that referenced
this issue
Sep 9, 2022
Introduced by cookpete/react-player#609 Fixes cookpete/react-player#675
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Current Behavior
example - <ReactPlayer style = {{translate: 'transform (50%,50%,0px)'}} />
style is applied once on the reactPlayer root div. and then again in the Vimeo.js file to the first div.
Expected Behavior
the styles should be applied only on the root div (this is what the readme states).
Other Information
some css like hight / width applied to parent and child div are not creating bugs because its just forcing the same height and its not visible (height is defined inline as 100% for Vimeo anyway). but other css like the transform3d is destructive when applied twice on top of eachother.
I created this fiddle to show what i mean:
fiddle
The text was updated successfully, but these errors were encountered: