Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve IBC Callbacks Helpers #2122

Closed
chipshort opened this issue Apr 22, 2024 · 0 comments · Fixed by #2167
Closed

Improve IBC Callbacks Helpers #2122

chipshort opened this issue Apr 22, 2024 · 0 comments · Fixed by #2167

Comments

@chipshort
Copy link
Collaborator

chipshort commented Apr 22, 2024

You could create an interesting API if you allow something like transfer_msg.with_src_callback(env, gas_limit) instead of writing it to the memo directly here. The method .with_src_callback would also return an error if the memo is not empty to ensure we are not overriding important info.

Provide something like a TransferMsgBuilder that takes everything except the memo and provides with_src_callback, with_dst_callback, with_callbacks, with_memo and without_memo to convert to a TransferMsg. That way you cannot misuse it accidentally.

Originally posted by @chipshort in #2025 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant