Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using addr_make inside AppBuilder::build #188

Closed
chipshort opened this issue Jun 17, 2024 · 2 comments · Fixed by #189
Closed

Using addr_make inside AppBuilder::build #188

chipshort opened this issue Jun 17, 2024 · 2 comments · Fixed by #189
Assignees
Milestone

Comments

@chipshort
Copy link
Contributor

This came up in a PR for the cw-template repo: CosmWasm/cw-template#158 (comment)

Because the init_fn only receives a &dyn Api, one cannot call api.addr_make using that.
Should we expose the actual ApiT to init_fn? Or is there a better way?

@DariuszDepta
Copy link
Member

Hey @chipshort and @Perelyn-sama, there is a PR #189 that addresses this issue. I'll be grateful for feedback.

@DariuszDepta DariuszDepta added this to the 2.1.0 milestone Jun 19, 2024
@Perelyn-sama
Copy link

Hey @DariuszDepta, thanks for the great article again.

I'll check out the PR you mentioned and send some feedback your way.🫡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants