-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add url as input when mint cw1155 #449
Comments
Is this for an NFT project? Can you check out the brand new https://github.com/CosmWasm/cw-nfts repo? We are trying to move all not related work there. If cw1155 work is primarily about NFTs, then maybe we can move that over as well. |
I know some projects that using ERC1155 for NFT (like SAND). The purpose of the opening issue was just curious that why there is the queryMsg that call url, even there are no way to put in. And good to hear about the cw-nfts repo. It just a personal opinion but CW1155 can be in there too. |
@yihuang wrote cw1155 contract I believe. Maybe he can answer. And also discuss if he wishes to move it to cw-nfts |
Yeah, I guess either set URL when mint or a dedicated message to manage the metadata URL is fine, no strong opinions on that. |
@ALPAC-4 do you want to make a PR for this change? To add metadata url on mint? We can discuss moving repos after the next release |
Once we feel good about the base |
Thanks for all your effort. I'm not a RUST dev. (I can just read some code) So I'll waiting for you. Thanks a lot |
I'm closing this here. @JakeHartnell is taking this over in cw-nfts repo (linked above) |
There are no way to put
url
in cw1155 at the base code but the query that call url is exist.So I think adding url as input at excute_mint function is reasonable.
The text was updated successfully, but these errors were encountered: