Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing events for admin-related methods #1173

Closed
tkxkd0159 opened this issue Jan 25, 2023 · 2 comments · Fixed by #1179
Closed

Missing events for admin-related methods #1173

tkxkd0159 opened this issue Jan 25, 2023 · 2 comments · Fixed by #1179
Assignees
@alpe
Milestone
v0.31.0

Comments

@tkxkd0159
Copy link

tkxkd0159 commented Jan 25, 2023 •
edited
Loading

There seems to be no event for setContractAdmin, setAccessConfig.
Is there any particular reason you didn't add events for these methods? Because I think this information is very important for everyone who use that contract. If not, I wanna add some events for them.
@alpe alpe added this to the v0.31.0 milestone Jan 25, 2023
@alpe
Copy link
Contributor

alpe commented Jan 25, 2023

You are right. There should be events. I will prepare a PR so that we get this into v0.31

@alpe alpe self-assigned this Jan 25, 2023
@tkxkd0159
Copy link
Author

Thank you for your answer and I need to use this event for my product. So I hope to make a PR now bc it's simple things.

@tkxkd0159 tkxkd0159 mentioned this issue Jan 26, 2023
Closed
@alpe alpe mentioned this issue Jan 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alpe alpe

Labels
None yet
Projects
None yet
Milestone
v0.31.0
2 participants
@alpe @tkxkd0159